Ali
830d621a87
The 0.1.9 placeholder repurposing didn't take effect on the test machine (account tree still showed XXXX rows even though E-Taxes Bank Account got populated). The most likely culprit was the manual doc.save() + frappe.rename_doc combo: doc.save runs Account.validate, which fires validate_account_currency and validate_account_number — either can throw on an in-place placeholder edit, leaving the account_name updated but the doc name stale, which dodges the XXXX-pattern delete sweep too. Switch to ERPNext's canonical update_account_number helper. It does the rename atomically, handles the tree-doctype reparenting, and is the exact path the in-app rename UI uses. Currency is set with a direct db.set_value beforehand so we never go through the full validate stack. Also expanded "Jey Wizard trace: bank native done" to a JSON dump that records, for every bank in the cache: currency, whether a same-currency placeholder was available, the resulting GL name, and the action taken (reused_placeholder / created_fresh / skipped_closed / error). Plus the placeholder_index keys/counts as seen at the start of the loop. Next run will show exactly which step is failing if anything still goes wrong. |
||
|---|---|---|
| jey_wizard | ||
| .editorconfig | ||
| .eslintrc | ||
| .gitignore | ||
| .pre-commit-config.yaml | ||
| CLAUDE.md | ||
| README.md | ||
| license.txt | ||
| pyproject.toml | ||
README.md
Jey Wizard
Jey Wizard
Installation
You can install this app using the bench CLI:
cd $PATH_TO_YOUR_BENCH
bench get-app $URL_OF_THIS_REPO --branch main
bench install-app jey_wizard
Contributing
This app uses pre-commit for code formatting and linting. Please install pre-commit and enable it for this repository:
cd apps/jey_wizard
pre-commit install
Pre-commit is configured to use the following tools for checking and formatting your code:
- ruff
- eslint
- prettier
- pyupgrade
License
unlicense