From 68ea3dce3893f4f3684ef1c199a28b1f336abd39 Mon Sep 17 00:00:00 2001 From: Ali <010109ali@gmail.com> Date: Fri, 15 May 2026 16:16:27 +0000 Subject: [PATCH] Revert clickable area: only digit + hint stay linked Wrapping the whole row turned the bold label into a link too, which read like a heading-as-button. Keep label plain, put the digit and the "(click to preview)" hint inside one anchor so they share a clickable target without hijacking the label. Co-Authored-By: Claude Opus 4.7 (1M context) --- jey_wizard/__init__.py | 2 +- jey_wizard/public/js/jey_setup.js | 18 ++++++++---------- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/jey_wizard/__init__.py b/jey_wizard/__init__.py index 19492a9..f7ee773 100644 --- a/jey_wizard/__init__.py +++ b/jey_wizard/__init__.py @@ -1 +1 @@ -__version__ = "0.1.27" +__version__ = "0.1.28" diff --git a/jey_wizard/public/js/jey_setup.js b/jey_wizard/public/js/jey_setup.js index 0340a99..c2a8ad8 100644 --- a/jey_wizard/public/js/jey_setup.js +++ b/jey_wizard/public/js/jey_setup.js @@ -10,7 +10,7 @@ frappe.provide("jey_wizard"); // Bump this string in every commit that changes wizard code. Displayed in the badge so // we can tell at a glance which version is actually running on a given machine. Kept in // sync with __version__ in jey_wizard/__init__.py. -const JEY_WIZARD_VERSION = "0.1.27"; +const JEY_WIZARD_VERSION = "0.1.28"; // Wipe Frappe + ERPNext default slides so their `before_load`/`after_load` listeners // don't try to mutate a wizard that isn't slide-based anymore. @@ -286,10 +286,9 @@ frappe.setup.SetupWizard = class JeySetupWizard { ["bank_accounts_json", "bank_accounts", __("Bank accounts")], ["presented_certs_json", "presented_certs", __("Presented certificates")], ]; - // Whole row is the clickable target so users don't have to aim - // at the digit. Anchor strips default underline + color, gets a - // soft hover background. - const linkStyle = "display:block;padding:4px 6px;border-radius:3px;text-decoration:none;color:inherit;cursor:pointer"; + // Label (the bold heading) stays plain text; only the digit + the + // "(click to preview)" hint sit inside the anchor so they share + // one clickable target. const rows = datasets.map(([field, kind, label]) => { if (errors[field]) { return `
  • ${label}: ${__("failed")} (${frappe.utils.escape_html(errors[field])})
    • `; @@ -299,18 +298,17 @@ frappe.setup.SetupWizard = class JeySetupWizard { return `
  • ${label}: —
    • `; } if (n > 0) { - return `
  • ${label}: ${n} ${__("(click to preview)")}
    • `; + return `
  • ${label}: ${n} ${__("(click to preview)")}
    • `; } return `
  • ${label}: ${n}
    • `; }).join(""); $body.html(` -

    ✓ ${__("Authenticated & data loaded")}

    ${__("Pulled from the tax portal:")}

    -