From 3b1b43a57cafe04ced860792210317d81623371d Mon Sep 17 00:00:00 2001 From: Ali <010109ali@gmail.com> Date: Wed, 13 May 2026 10:53:57 +0000 Subject: [PATCH] refactor(bank-integration): drop Skip Rows After Header from Excel Preset Only well-formed files (data rows immediately after the header) are expected; Header Row alone is enough to point the parser at the start of data. Co-Authored-By: Claude Opus 4.7 (1M context) --- jey_erp/bank_integration/excel_parser.py | 3 +-- jey_erp/fixtures/bank_integration_excel_preset.json | 1 - .../bank_integration_excel_preset.json | 8 -------- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/jey_erp/bank_integration/excel_parser.py b/jey_erp/bank_integration/excel_parser.py index 3753e38..98fd8ff 100644 --- a/jey_erp/bank_integration/excel_parser.py +++ b/jey_erp/bank_integration/excel_parser.py @@ -84,7 +84,6 @@ def parse_excel(file_url, preset_name): ws = wb.active header_row = preset.header_row or 1 - skip_after = preset.skip_rows_after_header or 0 all_rows = list(ws.iter_rows(values_only=True)) header_idx = header_row - 1 @@ -108,7 +107,7 @@ def parse_excel(file_url, preset_name): use_custom = bool(preset.get("use_custom_date_format")) custom_format = (preset.date_format or "").strip() if use_custom else "" amount_mode = preset.amount_mode or "Separate debit/credit columns" - data_start = header_idx + 1 + skip_after + data_start = header_idx + 1 transactions = [] dropped_date = 0 diff --git a/jey_erp/fixtures/bank_integration_excel_preset.json b/jey_erp/fixtures/bank_integration_excel_preset.json index e01437e..8a65b67 100644 --- a/jey_erp/fixtures/bank_integration_excel_preset.json +++ b/jey_erp/fixtures/bank_integration_excel_preset.json @@ -5,7 +5,6 @@ "preset_name": "Generic Bank Statement", "description": "Generic preset showing the supported standard fields. Copy this preset and adjust the Excel column names to match your bank's export format.", "header_row": 1, - "skip_rows_after_header": 0, "use_custom_date_format": 0, "date_format": "", "amount_mode": "Separate debit/credit columns", diff --git a/jey_erp/jey_erp/doctype/bank_integration_excel_preset/bank_integration_excel_preset.json b/jey_erp/jey_erp/doctype/bank_integration_excel_preset/bank_integration_excel_preset.json index 2b646ca..b4d1723 100644 --- a/jey_erp/jey_erp/doctype/bank_integration_excel_preset/bank_integration_excel_preset.json +++ b/jey_erp/jey_erp/doctype/bank_integration_excel_preset/bank_integration_excel_preset.json @@ -9,7 +9,6 @@ "description", "format_section", "header_row", - "skip_rows_after_header", "amount_mode", "column_break_1", "use_custom_date_format", @@ -47,13 +46,6 @@ "in_list_view": 1, "label": "Header Row" }, - { - "default": "0", - "description": "Number of rows to skip after the header row", - "fieldname": "skip_rows_after_header", - "fieldtype": "Int", - "label": "Skip Rows After Header" - }, { "default": "Separate debit/credit columns", "fieldname": "amount_mode",