ali
/
jey_erp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(bank-integration): clear validation message when default groups aren't set 

Creating customers/suppliers/bank accounts from unmapped rows fell back
to "All Customer Groups" / "All Territories" / "All Supplier Groups",
which don't exist on localized sites — ERPNext then threw a cryptic
"Could not find Customer Group: All Customer Groups". Now creation
validates upfront and returns a clear message ("Set a Default Customer
Group on the Bank Integration ...") before touching any records. Same
for Territory, Supplier Group, and (for Bank Accounts) Company / Bank.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ali 2026-05-12 10:31:34 +00:00
parent 1d6bdc8424
commit 2dba6908b0
1 changed files with 36 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
jey_erp/bank_integration/creation.py
View File

@ -19,6 +19,22 @@ def create_unmapped_customers(bank_integration):
if not unmapped: if not unmapped:
return {"success": True, "created_count": 0, "message": "No unmapped customers in table"} return {"success": True, "created_count": 0, "message": "No unmapped customers in table"}
# Validate config upfront — a clear message beats ERPNext's cryptic
# "Could not find Customer Group" thrown deep inside party creation.
for mapping, _bi_cust in unmapped:
group = mapping.customer_group or bi.default_customer_group
if not group or not frappe.db.exists("Customer Group", group):
frappe.throw(_(
"Set a Default Customer Group on the Bank Integration "
"(or a Customer Group on each customer mapping row) before creating customers."
))
territory = mapping.territory or bi.default_territory
if not territory or not frappe.db.exists("Territory", territory):
frappe.throw(_(
"Set a Default Territory on the Bank Integration "
"(or a Territory on each customer mapping row) before creating customers."
))
created = 0 created = 0
for mapping, bi_cust in unmapped: for mapping, bi_cust in unmapped:
try: try:
@ -29,16 +45,8 @@ def create_unmapped_customers(bank_integration):
party = frappe.new_doc("Customer") party = frappe.new_doc("Customer")
party.customer_name = customer_name party.customer_name = customer_name
party.customer_type = "Company" party.customer_type = "Company"
party.customer_group = mapping.customer_group or bi.default_customer_group
customer_group = mapping.customer_group or bi.default_customer_group or "All Customer Groups" party.territory = mapping.territory or bi.default_territory
if not frappe.db.exists("Customer Group", customer_group):
customer_group = "All Customer Groups"
party.customer_group = customer_group
territory = mapping.territory or bi.default_territory or "All Territories"
if not frappe.db.exists("Territory", territory):
territory = "All Territories"
party.territory = territory
if bi_cust.tax_id: if bi_cust.tax_id:
party.tax_id = bi_cust.tax_id party.tax_id = bi_cust.tax_id
@ -87,6 +95,14 @@ def create_unmapped_suppliers(bank_integration):
if not unmapped: if not unmapped:
return {"success": True, "created_count": 0, "message": "No unmapped suppliers in table"} return {"success": True, "created_count": 0, "message": "No unmapped suppliers in table"}
for mapping, _bi_supp in unmapped:
group = mapping.supplier_group or bi.default_supplier_group
if not group or not frappe.db.exists("Supplier Group", group):
frappe.throw(_(
"Set a Default Supplier Group on the Bank Integration "
"(or a Supplier Group on each supplier mapping row) before creating suppliers."
))
created = 0 created = 0
for mapping, bi_supp in unmapped: for mapping, bi_supp in unmapped:
try: try:
@ -97,11 +113,7 @@ def create_unmapped_suppliers(bank_integration):
party = frappe.new_doc("Supplier") party = frappe.new_doc("Supplier")
party.supplier_name = supplier_name party.supplier_name = supplier_name
party.supplier_type = "Company" party.supplier_type = "Company"
party.supplier_group = mapping.supplier_group or bi.default_supplier_group
supplier_group = mapping.supplier_group or bi.default_supplier_group or "All Supplier Groups"
if not frappe.db.exists("Supplier Group", supplier_group):
supplier_group = "All Supplier Groups"
party.supplier_group = supplier_group
if bi_supp.tax_id: if bi_supp.tax_id:
party.tax_id = bi_supp.tax_id party.tax_id = bi_supp.tax_id
@ -147,6 +159,13 @@ def create_unmapped_accounts(bank_integration):
default_bank = bi.default_bank default_bank = bi.default_bank
default_company = bi.default_company default_company = bi.default_company
# Only need these for accounts that don't already exist as Bank Accounts.
if any(not frappe.db.exists("Bank Account", {"bank_account_no": r.iban}) for r in unmapped):
if not default_company:
frappe.throw(_("Set a Default Company on the Bank Integration before creating Bank Accounts."))
if not default_bank:
frappe.throw(_("Set a Default Bank on the Bank Integration before creating Bank Accounts."))
created = 0 created = 0
for row in unmapped: for row in unmapped:
try: try:
@ -169,10 +188,8 @@ def create_unmapped_accounts(bank_integration):
ba.account_name = account_name ba.account_name = account_name
ba.bank_account_no = row.iban ba.bank_account_no = row.iban
ba.iban = row.iban ba.iban = row.iban
if default_bank: ba.bank = default_bank
ba.bank = default_bank ba.company = default_company
if default_company:
ba.company = default_company
ba.bank_integration_type = "Bank Integration" ba.bank_integration_type = "Bank Integration"
ba.bank_integration = bi.name ba.bank_integration = bi.name
ba.insert(ignore_permissions=True) ba.insert(ignore_permissions=True)